SUMMARY
ISSUE TYPE
COMPONENT NAMEvmware_portgroup ANSIBLE VERSIONADDITIONAL INFORMATIONIt's now possible to create or re-configure a standard switch port group with all options you can specify in the vSphere Client. Overrides are handled properly as well. |
Hi @ckotte, thank you for submitting this pull-request! |
The test ansible-test sanity --test validate-modules [explain] failed with 3 errors: |
cc @Akasurde@dav1x@warthog9 click here for bot help |
@ckotte, just so you are aware we have a dedicated Working Group for vmware. You can find other people interested in this in #ansible-vmware on Freenode IRCFor more information about communities, meetings and agendas see https://github.com/ansible/community |
The test ansible-test sanity --test validate-modules [explain] failed with 1 error: |
The test ansible-test sanity --test validate-modules [explain] failed with 1 error: |
One comment about document, the other comment is a bug in the code that occurs when a teaming config is not defined. |
description: |
- Dictionary which configures the different teaming values for portgroup. |
- 'Valid attributes are:' |
- '- C(load_balance_policy) (string): Network adapter teaming policy. (default: loadbalance_srcid)' |
load_balance_policy
as alias for load_balancing
within the code ? I am concerned about backward compatibility.Rest LGTM. Let me know once you are done. |
Rewrite vmware_portgroup module
9d0eb88
@pdellaert@dericcrago@Im0@tchernomax@jeking3 Could you please review this ? Thanks. |
I've tried to use this updated module to setup security policies on vmware 6.0 Sometimes (probably when there are no sec overrides for portgroup in vmware) the spec.policy.security is non-true in update_host_port_group function and portgroup is marked as changed even if no changes needed (because I have no security configuration for this portgroup in ansible) I've changed the code to mark portgroup as changed in case of non-true spec.policy.security object only when there is at least one security option set in ansible config |
Can you provide the task and the output? |
My test playbook: I've just created 'VM Network' portgroup without any security overrides Output with module from this pull request Output with my changes: Actually it would be great to generate a diff output, but I guess this could be done after this request merged Thanks for your work! |
cc @lparkes click here for bot help |
cc @Tomorrow9 click here for bot help |
cc @goneri click here for bot help |
superseded by #56382 |